Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable wifi collector by default #1037

Merged
merged 2 commits into from
Aug 7, 2018
Merged

Disable wifi collector by default #1037

merged 2 commits into from
Aug 7, 2018

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Aug 6, 2018

Disable the wifi collector by default due to suspected cashing issues and goroutine leaks.

Signed-off-by: Ben Kochie superq@gmail.com

Disable the wifi collector by default due to suspected cashing issues and goroutine leaks.
* #870
* #1008

Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ SuperQ requested a review from mdlayher August 6, 2018 15:10
@mdlayher
Copy link
Contributor

mdlayher commented Aug 6, 2018

*caching and then LGTM.

Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ SuperQ merged commit 0662673 into master Aug 7, 2018
@SuperQ SuperQ deleted the superq/no_wifi branch August 7, 2018 08:27
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
* Disable wifi collector by default

Disable the wifi collector by default due to suspected cashing issues and goroutine leaks.
* prometheus#870
* prometheus#1008

Signed-off-by: Ben Kochie <superq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants