Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mountstats collector for detailed NFS statistics #367

Merged
merged 1 commit into from
Dec 20, 2016
Merged

Add mountstats collector for detailed NFS statistics #367

merged 1 commit into from
Dec 20, 2016

Conversation

mdlayher
Copy link
Contributor

First pass at a mountstats collector for detailed NFS statistics. There are ~25 more statistics I can currently add but I wanted to check in my work before doing a bunch more.

Fixes #366 .

SuperQ
SuperQ approved these changes Dec 14, 2016
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot

@mdlayher
Copy link
Contributor Author

Awesome. @SuperQ, do you want me to tack more changes onto this PR, or make a new one for the additional stats?

@SuperQ
Copy link
Member

SuperQ commented Dec 15, 2016

No, I think we should do this incrementally. I'd like to get one other thumb from someone, maybe @beorn7 or @grobie.

beorn7
beorn7 requested changes Dec 20, 2016
View reviewed changes
Copy link
Member

@beorn7 beorn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, just the confusion about the "items in queue" metrics, if they are Gauges or Counters. (If the latter, the help string should be reworded, something like "total number of items added to the queue" or something.)

collector/mountstats_linux.go

NFSTransportBacklogQueueTotal: prometheus.NewDesc(
prometheus.BuildFQName(Namespace, subsystem, "transport_backlog_queue_total"),
"Number of items in the RPC backlog queue.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like it could go down, i.e. it should be a Gauge?

collector/mountstats_linux.go

NFSTransportSendingQueueTotal: prometheus.NewDesc(
prometheus.BuildFQName(Namespace, subsystem, "transport_sending_queue_total"),
"Number of items in the RPC transmission sending queue.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, help string suggests a Gauge.

collector/mountstats_linux.go

NFSTransportPendingQueueTotal: prometheus.NewDesc(
prometheus.BuildFQName(Namespace, subsystem, "transport_pending_queue_total"),
"Number of items in the RPC transmission pending queue.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

@mdlayher
Copy link
Contributor Author

@beorn7 good call. According the docs I followed while parsing these stats:

cumulative backlog count: Every time we send a request, we add the current backlog queue size to this counter.
...
cumulative sending queue count: Every time we send a request, we add the current size of the sending queue to this counter.
cumulative pending queue count: Every time we send a request, we add the current size of the pending queue to this counter.

Based on these descriptions, I believe your suggestion of "total number of items added to the queue" will be adequate.

@mdlayher
Copy link
Contributor Author

@beorn7 Updated. Please take a look at your convenience.

@beorn7
Copy link
Member

beorn7 commented Dec 20, 2016

In lack of more qualified reviewers, I'll approve and merge.

@beorn7 beorn7 merged commit 08c9347 into prometheus:master Dec 20, 2016
@mdlayher mdlayher deleted the mountstats branch December 20, 2016 16:23
@discordianfish discordianfish mentioned this pull request Dec 20, 2016
Closed
@SuperQ SuperQ mentioned this pull request Jan 15, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beorn7 beorn7 beorn7 approved these changes

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdlayher @SuperQ @beorn7