Remove netbsd/arm support for now #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are crossbuild errors on netbsd/arm with go1.8. Assuming there is only a small minority of people running netbsd on ARM processors, disabling these builds is the fastest workaround.
|
Hrm platform isn't uncommon.. But I guess it's okay to merge this for now, but we need to revive that before the next release. |
|
See the mailing list thread on prometheus-developers@. Given the amount of os/arch combinations we already disabled due to crossbuild issues, I guess we'll need to invest time in a (VM based?) native build fleet. At the moment we either have broken builds or no netbsd/arm. |
|
@SuperQ Cool with you? This will allow us to merge all the outstanding PRs for now. |
|
Couldn't even get the amd64 binaries to run before: #402 |
|
LGTM, I'd like to keep the auto-builds moving forward. |
tamcore
pushed a commit
to gitgrave/node_exporter
that referenced
this pull request
Oct 22, 2024
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are crossbuild errors on netbsd/arm with go1.8. Assuming there is
only a small minority of people running netbsd on ARM processors,
disabling these builds is the fastest workaround.
@derekmarcotte @sdurrheimer