Add XFS block mapping and block map B-tree stats #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
reviewed
May 3, 2017
collector/xfs_linux.go
Outdated
| { | ||
| name: "block_mapping_extent_list_compares_total", | ||
| desc: "Number of extent list compares for a filesystem.", | ||
| value: float64(0), |
There was a problem hiding this comment.
Err, why add a counter if it's always going to be 0?
There was a problem hiding this comment.
Oops. :) Totally forgot to fill these in when I was copying/pasting slice elements. Will fix.
|
@SuperQ updated. |
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
tamcore
pushed a commit
to gitgrave/node_exporter
that referenced
this pull request
Oct 22, 2024
Enable CI testing of Go 1.21. * Bump Go modules. Signed-off-by: SuperQ <superq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of my previous XFS collector work. Many stats left, but I'll keep adding them in chunks to make it more manageable.