Multiply port data XMIT/RCV metrics by 4 #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't heard anything on #573 so I decided to go ahead an make a change. Let me know if this is the desired way to fix the issue, otherwise I can refactor however anyone sees fit! |
SuperQ
approved these changes
May 11, 2017
collector/infiniband_linux.go
Outdated
| @@ -148,6 +148,11 @@ func readMetric(directory, metricFile string) (uint64, error) { | |||
| return 0, err | |||
| } | |||
|
|
|||
| switch metricFile { | |||
| case "port_rcv_data", "port_xmit_data", "port_rcv_data_64", "port_xmit_data_64": | |||
There was a problem hiding this comment.
Maybe put a comment here about why we're doing this, either link to docs, or link to issue.
There was a problem hiding this comment.
Good call - I'm on it!
According to Mellanox, it is standard practice that the port_xmit_data and port_rcv_data files are split into 4 lanes. To get the actual transmit and receive values for each port, the metric needs to be multiplied by 4. Signed-Off-By: Robert Clark <robert.d.clark@hpe.com>
roclark
force-pushed
the
multiply-infiniband-lanes
branch
from
4c636f3
to
49d79b5
Compare
grobie
approved these changes
May 11, 2017
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
According to Mellanox, it is standard practice that the port_xmit_data and port_rcv_data files are split into 4 lanes. To get the actual transmit and receive values for each port, the metric needs to be multiplied by 4. Signed-Off-By: Robert Clark <robert.d.clark@hpe.com>
tamcore
pushed a commit
to gitgrave/node_exporter
that referenced
this pull request
Oct 22, 2024
Signed-off-by: Felix Aronsson <felixaronsson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Mellanox, it is standard practice that the port_xmit_data and port_rcv_data
files are split into 4 lanes. To get the actual transmit and receive values for each
port, the metric needs to be multiplied by 4.
If applied, this fixes #573.
Signed-Off-By: Robert Clark robert.d.clark@hpe.com