Add NFS Server metrics collector. #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdlayher
approved these changes
Jan 26, 2018
collector/nfsd_linux.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| nfsdReplyCacheHitsDesc = prometheus.NewDesc( |
There was a problem hiding this comment.
Nit, but I'd make these fields on the nfsdCollector type so you don't pollute the package level with variables.
There was a problem hiding this comment.
Ok, I'll move things around.
collector/nfsd_linux.go
Outdated
| return nil | ||
| } | ||
|
|
||
| // updateNFSdReplyCacheStats collects statistics for a single XFS filesystem. |
SuperQ
force-pushed
the
superq/nfsd
branch
2 times, most recently
from
63db1c1
to
460f5ff
Compare
|
@mdlayher Ok, I moved the desc stuff into the update function, does that seem like the right way to you? |
|
LGTM, beside the help strings. |
|
LGTM |
collector/nfsd_linux.go
Outdated
| ch <- prometheus.MustNewConstMetric( | ||
| prometheus.NewDesc( | ||
| prometheus.BuildFQName(namespace, nfsdSubsystem, "reply_cache_hits_total"), | ||
| "NFSd Reply Cache client did not receive a reply and decided to re-transmit its request and the reply was cached. (bad).", |
There was a problem hiding this comment.
I'm fine with having an explaination here, but it should still follow the form of metric help strings, e.g "Total number of something something".
There was a problem hiding this comment.
This was a copy-n-paste from the blog post. I'll clean it up a bit.
SuperQ
changed the title
|
@discordianfish Ok, I've updated all the help text, PTAL. |
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* Add NFS Server metrics collector. * Add File Handles metrics. * Add nfsd IO stats. * Add metrics for NFSd threads. * Add metrics for NFSd read ahead cache. * Add NFSd network traffic counters. * Add RPC metrics. * Add V2 requests metrics. * Add NFSv3 metrics. * Add NFSv4 metrics. * Update reply cache comment. * Update help text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for various Linux NFS Kernel Server metrics read from
/proc/net/rpc/nfsd.Closes: #607