Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang to 1.10.1 #915

Closed
wants to merge 1 commit into from
Closed

Update golang to 1.10.1 #915

wants to merge 1 commit into from

Conversation

discordianfish
Copy link
Member

This might fix #870, saw a bunch of issues with 1.10 in other repos.

@SuperQ
Copy link
Member

SuperQ commented Apr 19, 2018

I don't think this is necessary, as the circleci/golang:1.10 image is already updated to 1.10.1.

INFO[0000] Starting node_exporter (version=0.16.0-rc.1, branch=HEAD, revision=f3ff44fcca5bb20a181cd7b99734afeae553c78e)  source="node_exporter.go:82"
INFO[0000] Build context (go=go1.10.1, user=root@448aa887a7ca, date=20180404-17:47:46)  source="node_exporter.go:83"

@discordianfish
Copy link
Member Author

Oops, you're right. Just realize we already ruled this possibility out in the issue.

@mdlayher mdlayher deleted the fish-bump-go-1.10.1 branch October 16, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fatal error: runtime.unlock: lock count with Go >= 1.10
2 participants
@discordianfish @SuperQ