-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add powercom MIBs #1275
Add powercom MIBs #1275
Conversation
Powecom MIBs are added and tested against DA807 card so looks working (i.e metrics are present and even named correctly during scrape), however It's my first dance with SNMP and adding MIBs to snmp exporter so please check it carefully before merging :) Thanks! |
Based on CI run there's amount of lgpPdu* metrics generated (probably from other MIBs?), could someone please advise how to ignore them and leave only upsSmart* ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to generate the snmp.yml and update it for CI to pass.
Signed-off-by: Igor Shishkin <me@teran.dev>
Signed-off-by: Igor Shishkin <me@teran.dev>
Signed-off-by: Igor Shishkin <me@teran.ru>
Now it should be fine, CI is passed, all relevant metrics are in place and I've checked it against real DA807 - metrics are also there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like you're just including everything possible. This isn't usually a good idea as there are lots of walks that don't provide value. For example you have included mconfigTrapsReceiversTable
which doesn't seem to be very useful.
@SuperQ I've updated the list of OIDs to contain the only ones meaning and not empty, however it's probably not the whole list and it's up to update while users will use the module since this card (DA807) will probably fit into amount of UPS' devices. Descriptions are also added. CI is failed at the moment because upspowercom.com is down at the moment so it's up to retrigger the build. Thank you for your guidance :-) |
Signed-off-by: Igor Shishkin <me@teran.ru>
Signed-off-by: Igor Shishkin <me@teran.ru>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Powercom MIBs, tested against NetAgent DA807