Adding Jubjub signature verification PCD #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichub
requested changes
Apr 14, 2023
Co-authored-by: Ivan Chub <ichub@users.noreply.github.com>
ichub
reviewed
Apr 18, 2023
Co-authored-by: Ivan Chub <ichub@users.noreply.github.com>
Co-authored-by: Ivan Chub <ichub@users.noreply.github.com>
ichub
reviewed
Apr 24, 2023
|
Updated to lock PCD package versions. I think the JubJub Signature PCD is imported where it needs to. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists into two things:
Adding
Bufferas a polyfill within the passport-client. Quite a few libs leverageBuffer. Without a polyfill, PCD builders may quickly find themselves limited. In my case, I was not able to carry out signature verification.Adding a
jubjub-signature-pcdpackage. This package is a PCD that proves that the user holds a valid jubjub signature. The user also proves that he knows the pre-image of the signed message/hash. For now, the package is only loaded inlocalstorage.ts. I was not too sure whether it made sense to add it todispatch.ts, since this PCD will be mainly serving for demo purposes at zuzalu.