feat: add SendWithContext #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Jon, sorry for the late reply - thank you so much for this! In the next days I'll review it. Could you kindly maybe add a test case? Thanks again! |
|
@proofrock hey no worries! I have added a test case for a cancelled context. |
jonlundy
force-pushed
the
context
branch
2 times, most recently
from
f90c62e to
ffd2612
Compare
|
Excellent! Very nice, thanks a lot. Now I only have to figure out how to apply this to the |
|
Oh! i can switch to that one |
|
That would be great. If you can't, I'll try to rebase on develop, but the risk is that GitHub doesn't show your contribution on the project page... :-( |
|
@proofrock done. cherry-picked over to develop |
|
Ok, done. Thanks a whole lot!! |
|
Tested and released. Again, many many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.