bug(console): Team and contacts email selection doesn't persist #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betimshahini
reviewed
Jun 5, 2023
| //TODO: Temp fix. To be removed with full fix of typing issue | ||
| //@ts-ignore | ||
| if (selected === appContactAddress) { | ||
| if (selected.value === appContactAddress) { | ||
| return | ||
| } | ||
| if (!selected) { |
There was a problem hiding this comment.
Does this also need to have .value added to it? If not, might want to move it up before the previous if-statement and change the error message.
There was a problem hiding this comment.
Generally speaking if selected is presented here it includes that .value attached to it. However to be on the safe side I included both checks and moved it up with changing error message.
poolsar42
force-pushed
the
fix/2353-console-teams-email-selection
branch
from
333d3a2
to
8f6bf5e
Compare
betimshahini
approved these changes
Jun 5, 2023
poolsar42
added a commit
that referenced
this pull request
Jun 5, 2023
poolsar42
added a commit
that referenced
this pull request
Jun 5, 2023
poolsar42
added a commit
that referenced
this pull request
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes types in Dropdown component for selected values
Related Issues
Testing
Tested teams section in console as well as authorize component for all scopes in passport
Checklist