Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(console): Group seat page structure #2683

Merged
merged 12 commits into from
Sep 21, 2023
Merged

feat(console): Group seat page structure #2683

merged 12 commits into from
Sep 21, 2023

Conversation

Cosmin-Parvulescu
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu commented Sep 13, 2023 •
edited
Loading

Description

  • Added group seat card model for group billing page
  • Added reusable seat purchase modal
  • Added client side feature flagging

Related Issues

Testing

Enable the feature by visiting any console url with the feature_flag=seats query parameter.

Light integration in group billing page:
image

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@Cosmin-Parvulescu Cosmin-Parvulescu added the enhancement Indicates new feature requests label Sep 13, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Sep 13, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review September 13, 2023 14:44
betimshahini
betimshahini requested changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@betimshahini betimshahini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you integrate into billing page, under a feature flag?

@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/console/group-seat-page-structure branch from 5432146 to 76a390b Compare September 15, 2023 07:44
@Cosmin-Parvulescu
Copy link
Contributor Author

Cosmin-Parvulescu commented Sep 15, 2023 •
edited
Loading

Can you integrate into billing page, under a feature flag?

I added an env based feature flag (alternative would be code based I suppose). Let me know if that's ok.

FEATURE_FLAGS = "seats,..."

@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as draft September 15, 2023 14:31
@Cosmin-Parvulescu
Copy link
Contributor Author

  • Add client side feature flagging (using localStorage, react hooks and maps :>)
  • Add $ to the seating panel

@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/console/group-seat-page-structure branch from 527cced to 5ff0444 Compare September 18, 2023 09:46
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review September 18, 2023 09:55
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/console/group-seat-page-structure branch from 922b16b to ba8f95e Compare September 21, 2023 08:08
@betimshahini betimshahini merged commit 8b1e419 into main Sep 21, 2023
14 checks passed
@betimshahini betimshahini deleted the feat/console/group-seat-page-structure branch September 21, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betimshahini betimshahini betimshahini approved these changes

@picassobanana picassobanana Awaiting requested review from picassobanana

Assignees

@Cosmin-Parvulescu Cosmin-Parvulescu

Labels
enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(console): Group seat page structure
2 participants
@Cosmin-Parvulescu @betimshahini