Convert transaction manager to event store plugin #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @prolic |
prolic
added a commit
that referenced
this pull request
Nov 5, 2015
Convert transaction manager to event store plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the usage of the transaction manager as event store plugin instead of requiring the event store in the constructor of the transaction manager. Also the transaction manager factory is aligned so that the event store is no longer pulled from the container.
Main reason for the change was a circular dependency problem when the transaction manager is used together with the snapshot plugin.
For the record the old dependency chain compared with the new one:
CommandBus -> TransactionManager -> EventStore -> SnapshotPlugin <- (circular dep) CommandBus
new deps starting from event store as both plugins are event store plugins now:
CommandBus <- SnapshotPlugin <- EventStore -> TransactionManager -> CommandBus