Dispatch EVENT_APPEND_TO and EVENT_CREATE in transactional event store when not inside transaction #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codeliner wanna check as well? |
codeliner
approved these changes
Apr 4, 2018
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations, a transactional event store might be used without a transaction manager or any transaction at all. However, with current implementation, is only possible to publish events from a transactional event store when a transaction is commited.
I think that behaviour would be more accurate if event publisher not only checks if the event store is transactional but if it's wrapped in a transaction in order to publish or cache them until transaction commit/rollback.