Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfixes and tests #22

Merged
merged 4 commits into from
Oct 27, 2018
Merged

bugfixes and tests #22

merged 4 commits into from
Oct 27, 2018

Conversation

prolic
Copy link
Member

@prolic prolic commented Oct 26, 2018

No description provided.

@prolic prolic added the bug Something isn't working label Oct 26, 2018
@prolic prolic requested a review from codeliner October 26, 2018 20:46
@coveralls
Copy link

coveralls commented Oct 26, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 165

  • 28 of 35 (80.0%) changed or added relevant lines in 3 files are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.05%) to 46.419%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Internal/AbstractEventStorePersistentSubscription.php 3 6 50.0%
src/Internal/EventStoreCatchUpSubscription.php 6 10 60.0%
Files with Coverage Reduction New Missed Lines %
src/Internal/IdentifyInfo.php 1 80.0%
src/Internal/EventStoreConnectionLogicHandler.php 1 76.43%
src/Internal/SubscriptionItem.php 3 54.05%
src/Internal/SubscriptionsManager.php 4 45.19%
Totals Coverage Status
Change from base Build 157: 0.05%
Covered Lines: 3876
Relevant Lines: 8350
💛 - Coveralls

@prolic
Copy link
Member Author

prolic commented Oct 26, 2018

@codeliner why is --exclude-group=ignore on phpunit ignored on one build? I don't get it.

@prolic
Copy link
Member Author

prolic commented Oct 26, 2018

Ah me stupid, found it :)

@codeliner codeliner merged commit dd1a131 into master Oct 27, 2018
@codeliner codeliner deleted the bugfixes branch October 27, 2018 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeliner codeliner codeliner approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prolic @coveralls @codeliner