Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type=JS from ProjectionsClient::updateQuery() #59

Merged
merged 1 commit into from
Dec 6, 2018

Conversation

enumag
Copy link
Member

@enumag enumag commented Dec 6, 2018

Closes #56

I think this is the easiest fix. When updating a query we don't need to specify the projection type.

@enumag enumag changed the title Remove type=JS from ProjectionsClient::updateQuery() (closes #56)) Remove type=JS from ProjectionsClient::updateQuery() (closes #56) Dec 6, 2018
@enumag enumag changed the title Remove type=JS from ProjectionsClient::updateQuery() (closes #56) Remove type=JS from ProjectionsClient::updateQuery() Dec 6, 2018
@prolic prolic added the bug Something isn't working label Dec 6, 2018
@prolic prolic merged commit dc36bdf into prooph:master Dec 6, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 305

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.967%

Totals Coverage Status
Change from base Build 301: 0.0%
Covered Lines: 4447
Relevant Lines: 6952

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imposibility to edit native projections
3 participants