Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor event appeared callbacks #65

Merged
merged 1 commit into from
Dec 8, 2018
Merged

refactor event appeared callbacks #65

merged 1 commit into from
Dec 8, 2018

Conversation

prolic
Copy link
Member

@prolic prolic commented Dec 8, 2018

@pkruithof note this change as well

@prolic prolic added the enhancement New feature or request label Dec 8, 2018
@prolic prolic self-assigned this Dec 8, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 334

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 67.099%

Files with Coverage Reduction New Missed Lines %
src/Exception/PersistentSubscriptionCommandFailedException.php 6 0.0%
src/PersistentSubscriptions/PersistentSubscriptionsClient.php 7 72.04%
Totals Coverage Status
Change from base Build 333: -0.2%
Covered Lines: 4289
Relevant Lines: 6392

💛 - Coveralls

@prolic
Copy link
Member Author

prolic commented Dec 8, 2018

Also resolves #44

@prolic prolic merged commit fdbe31d into master Dec 8, 2018
@prolic prolic deleted the refactor_callbacks branch December 8, 2018 14:17
@pkruithof
Copy link
Contributor

As it seems, only internal stuff has changed, right? There were some points where we had to require internal classes, so I'll check those. But this mostly shouldn't affect anything, I think.

@prolic
Copy link
Member Author

prolic commented Dec 10, 2018

Mostly internal stuff, correct. But note your callbacks expect ResolvedEvent now and not Internal\ResolvedEvent.

@pkruithof
Copy link
Contributor

Yeah, already updated those :-)

The only internal class I need to use right now is Prooph\EventStoreClient\Internal\EventStorePersistentSubscription

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants