Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of Symfony 5.0 #68

Merged
merged 8 commits into from
Dec 18, 2019
Merged

Add support of Symfony 5.0 #68

merged 8 commits into from
Dec 18, 2019

Conversation

ptondereau
Copy link

@ptondereau ptondereau commented Dec 13, 2019

I tried to support maximum version of Symfony LTS versions.

Because of https://github.com/SymfonyTest/SymfonyDependencyInjectionTest 's requirements, I've dropped 4.3 version (4.4 is now a LTS).

I've reworked the travis CI configuration to support Symfony Messenger in both 3.4 and >=4.

  • Tests now pass with all LTS versions of Symfony (3.4, 4.4, 5.0)

@coveralls
Copy link

coveralls commented Dec 13, 2019

Pull Request Test Coverage Report for Build 243

  • 18 of 28 (64.29%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 88.951%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Command/ProjectionDeleteCommand.php 0 1 0.0%
src/Command/ProjectionResetCommand.php 0 1 0.0%
src/Command/ProjectionStopCommand.php 0 1 0.0%
src/DependencyInjection/Configuration.php 8 11 72.73%
src/Command/AbstractProjectionCommand.php 0 4 0.0%
Totals Coverage Status
Change from base Build 208: 0.3%
Covered Lines: 475
Relevant Lines: 534

💛 - Coveralls

@ptondereau ptondereau marked this pull request as ready for review December 17, 2019 14:48
@codeliner codeliner merged commit 70b6e6d into prooph:master Dec 18, 2019
@ptondereau ptondereau deleted the update-symfony-5 branch December 18, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants