Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for missing return type TreeBuilder from ConfigurationInterface in Symfony 7 #95

Merged

Conversation

mkilmanas
Copy link
Contributor

Fixes this incompatibility with Symfony 7 (or symfony/config:^7.0 to be precise):

PHP Fatal error:  Declaration of Prooph\Bundle\EventStore\DependencyInjection\Configuration::getConfigTreeBuilder() must be compatible with Symfony\Component\Config\Definition\ConfigurationInterface::getConfigTreeBuilder(): Symfony\Component\Config\Definition\Builder\TreeBuilder in /.../vendor/prooph/event-store-symfony-bundle/src/DependencyInjection/Configuration.php on line 29

P.S. For whatever reason running composer install in this bundle's repository, even with --no-dev still refuses to install symfony/config v7.0+ - so the issue is not immediately obvious, but it popped up in an actual project.
Heres symfony interface now: https://github.com/symfony/symfony/blob/7.0/src/Symfony/Component/Config/Definition/ConfigurationInterface.php

@mkilmanas
Copy link
Contributor Author

@unixslayer any chance you could have a look at this, and make a patch release if possible?

@coveralls
Copy link

coveralls commented May 27, 2024

Pull Request Test Coverage Report for Build 9227591538

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.939%

Totals Coverage Status
Change from base Build 9179036425: 0.0%
Covered Lines: 527
Relevant Lines: 561

💛 - Coveralls

@unixslayer unixslayer merged commit ebddd29 into prooph:master May 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants