Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't remove deprecated config option #22

Merged
merged 1 commit into from
Mar 31, 2018
Merged

Don't remove deprecated config option #22

merged 1 commit into from
Mar 31, 2018

Conversation

sandrokeil
Copy link
Member

@sandrokeil sandrokeil commented Mar 29, 2018 •
edited
Loading

@basz @prolic Here is a test case for this.

@sandrokeil sandrokeil mentioned this pull request Mar 29, 2018
Merged
@coveralls
Copy link

coveralls commented Mar 29, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 83.051% when pulling 13cfba5 on sandrokeil:bugfix/config-objects into 70ecea8 on prooph:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 83.051% when pulling 00e76ea on sandrokeil:bugfix/config-objects into 70ecea8 on prooph:master.

@prolic
Copy link
Member

prolic commented Mar 29, 2018

Tests failed?

@prolic
Copy link
Member

prolic commented Mar 29, 2018

Cs issues

@sandrokeil sandrokeil force-pushed the bugfix/config-objects branch from 00e76ea to 13cfba5 Compare March 31, 2018 09:08
@sandrokeil
Copy link
Member Author

@prolic Fixed

@prolic prolic merged commit f0663ac into prooph:master Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandrokeil @coveralls @prolic