Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds PKs to schema's #24

Merged
merged 3 commits into from
Apr 15, 2018
Merged

adds PKs to schema's #24

merged 3 commits into from
Apr 15, 2018

Conversation

basz
Copy link
Member

@basz basz commented Apr 13, 2018

fixes #23

@coveralls
Copy link

coveralls commented Apr 13, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 83.051% when pulling 9aac4d9 on basz:issues/23 into f0663ac on prooph:master.

prolic
prolic requested changes Apr 14, 2018
View reviewed changes
Copy link
Member

@prolic prolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also put the ALTER TABLE statements in readme for users who need to upgrade the database manually? Also maybe a note, that alternatively they can simply drop snapshot tables and reset snapshotter projection?

scripts/mysql_snapshot_table.sql Outdated
@@ -4,5 +4,6 @@ CREATE TABLE `snapshots` (
`last_version` INT(11) NOT NULL,
`created_at` CHAR(26) NOT NULL,
`aggregate_root` BLOB,
PRIMARY KEY (`aggregate_id`),
UNIQUE KEY `ix_aggregate_id` (`aggregate_id`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unique can be removed

@basz
Copy link
Member Author

basz commented Apr 14, 2018

done

@prolic prolic merged commit d1d840a into prooph:master Apr 15, 2018
@prolic prolic added the bug label Apr 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prolic prolic prolic approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

snapshot have no index (postgres)
3 participants
@basz @coveralls @prolic