Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly escape schema namespaced table name in the PostgreSQL. #30

Merged
merged 3 commits into from
Apr 26, 2019
Merged

Correctly escape schema namespaced table name in the PostgreSQL. #30

merged 3 commits into from
Apr 26, 2019

Conversation

ghettovoice
Copy link
Contributor

@ghettovoice ghettovoice commented Apr 25, 2019 •
edited
Loading

Just a bit fix for pgsql that allows use of schema namespaced table names.
Like in the pdo-event-store.

This allows to setup read model tables like this:

app.users - read projection
app.user_spanshots - user aggregate snapshots

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 81.102% when pulling 16e8aa9 on ghettovoice:master into e014eac on prooph:master.

@coveralls
Copy link

coveralls commented Apr 25, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.7%) to 83.465% when pulling 6054149 on ghettovoice:master into e014eac on prooph:master.

@prolic
Copy link
Member

prolic commented Apr 25, 2019

Can you add a unit test please?

@ghettovoice
Copy link
Contributor Author

Yes, sure. I'll add a bit later

@ghettovoice
Copy link
Contributor Author

Done. But there are 2 failed jobs with code style issues.

@prolic
Copy link
Member

prolic commented Apr 25, 2019 via email

@ghettovoice
Copy link
Contributor Author

No problem. All done.

@prolic prolic merged commit 9240e89 into prooph:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prolic prolic prolic approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghettovoice @coveralls @prolic