Bump service bus package #10

mablae · 2017-01-03T21:13:44Z

WIP

codeliner · 2017-01-04T06:12:08Z

travis is red. travis.yml needs update like https://github.com/prooph/event-store/blob/develop/.travis.yml#L6

codeliner · 2017-01-04T06:27:00Z

some updates in the package are required, too.
The PluginsPass will no longer work:
https://github.com/prooph/service-bus-symfony-bundle/blob/master/src/DependencyInjection/Compiler/PluginsPass.php#L39

New set up is:
$plugin->attachToMessageBus($messageBus)
See: https://github.com/prooph/service-bus/blob/develop/src/Container/AbstractBusFactory.php#L133

So we need something like we already use in the event-store-symfony-bundle:
https://github.com/prooph/event-store-symfony-bundle/blob/master/src/DependencyInjection/Compiler/PluginsPass.php
and
https://github.com/prooph/event-store-symfony-bundle/blob/master/src/EventStoreFactory.php#L31

Unfortunately, a lot of changes required for the service-bus-bundle :(
@mablae Do you want to continue? Let me know if something is not clear.

mablae · 2017-01-04T08:24:50Z

@codeliner Thanks for your valuable feedback. I will continue with this PR tonight and then look into
event-store-bundle, too.

Also it should be a new v2.0.0 instead of a v0.3 version with prooph v7 I guess?

This PR was not meant to be merged yet, I forgot to add the WIP

prolic · 2017-01-04T08:38:09Z

v0.3 is correct

UFOMelkor · 2017-01-04T11:49:38Z

How about tagging the current version as v0.3 and the prooph-v7 one as v0.4?

prolic · 2017-01-04T11:53:06Z

We can do that. Am 04.01.2017 7:49 nachm. schrieb "Oskar Pfeifer-Bley" < notifications@github.com>:

…

How about tagging the current version as v0.3 and the prooph-v7 one as v0.4? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#10 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYEvG3rAoUN-Z_g0O6TgQHVI6jDMy4Kks5rO4dSgaJpZM4LaCAJ> .

prolic · 2017-01-04T12:31:47Z

v0.3 released: https://github.com/prooph/service-bus-symfony-bundle/releases/tag/v0.3

UFOMelkor · 2017-01-04T12:46:12Z

Thx :-)

- Introduce MessageBusFactory to control the reversed way of plugin attaching - Add onEvent and handle method to Fixture Model handlers and listeners - Test for factory - Use factory in abstract service definitions

mablae · 2017-01-08T18:13:22Z

@codeline @prolic I have updated and rebased everything. This PR depends on prooph/service-bus#151

UFOMelkor

Some small notes …

UFOMelkor · 2017-01-09T17:11:34Z

.travis.yml


 before_install:
  - if [[ $EXECUTE_TEST_COVERALLS != 'true' ]]; then phpenv config-rm xdebug.ini || return 0 ; fi
-  - composer self-update
+  - composer update --prefer-dist $DEPENDENCIES


Replacement of self-update with update intended?

UFOMelkor · 2017-01-09T17:13:35Z

.travis.yml


 before_install:
  - if [[ $EXECUTE_TEST_COVERALLS != 'true' ]]; then phpenv config-rm xdebug.ini || return 0 ; fi
-  - composer self-update
+  - composer update --prefer-dist $DEPENDENCIES
  - if [[ $EXECUTE_TEST_COVERALLS == 'true' ]]; then composer require --no-update satooshi/php-coveralls:dev-master ; fi

 install:
  - travis_retry composer install --no-interaction --prefer-source


Does this have any effect after composer update in before_install?

UFOMelkor · 2017-01-09T17:14:49Z

src/DependencyInjection/ProophServiceBusExtension.php

@@ -35,6 +36,7 @@
        'query' => QueryBus::class,
    ];

+


Two empty lines intended?

UFOMelkor · 2017-01-09T17:20:02Z

src/DependencyInjection/ProophServiceBusExtension.php

@@ -118,51 +120,65 @@ private function busLoad(
     */
    private function loadBus(string $type, string $name, array $options, ContainerBuilder $container)
    {
+        $serviceBusName = sprintf('prooph_service_bus.%s', $name);


String concatenation is used 8 times while sprintf is used three times. Perhaps we can unify this to string concatenation?

UFOMelkor · 2017-01-09T17:22:06Z

src/DependencyInjection/ProophServiceBusExtension.php

@@ -118,51 +120,65 @@ private function busLoad(
     */
    private function loadBus(string $type, string $name, array $options, ContainerBuilder $container)
    {
+        $serviceBusName = sprintf('prooph_service_bus.%s', $name);


$serviceBusId would be more consistent.

UFOMelkor · 2017-01-09T17:24:54Z

src/DependencyInjection/ProophServiceBusExtension.php

+        $containerPluginId = 'prooph_service_bus.container_plugin';
+        $pluginIds = array_filter(array_merge($options['plugins'], [$containerPluginId, $messageFactoryPluginId, $routerId]));
+
+


Two empty lines intended?

UFOMelkor · 2017-01-09T17:27:52Z

src/Resources/config/command_bus.xml

+        <service id="prooph_service_bus.command_bus" class="%prooph_service_bus.command_bus.class%" abstract="true" >
+            <factory service="prooph_service_bus.command_bus_factory" method="create"/>
+        </service>
+        <service id="prooph_service_bus.command_bus_factory" class="%prooph_service_bus.message_bus_factory.class%"/>


Not sure but factory might be set to public=false

UFOMelkor · 2017-01-09T17:32:39Z

src/Resources/config/event_bus.xml

+        <service id="prooph_service_bus.event_bus" class="%prooph_service_bus.event_bus.class%" abstract="true" >
+            <factory service="prooph_service_bus.event_bus_factory" method="create"/>
+        </service>
+        <service id="prooph_service_bus.event_bus_factory" class="%prooph_service_bus.message_bus_factory.class%"/>


See comment above.

UFOMelkor · 2017-01-09T17:32:54Z

src/Resources/config/query_bus.xml

+        <service id="prooph_service_bus.query_bus" class="%prooph_service_bus.query_bus.class%" abstract="true" >
+            <factory service="prooph_service_bus.query_bus_factory" method="create"/>
+        </service>
+        <service id="prooph_service_bus.query_bus_factory" class="%prooph_service_bus.message_bus_factory.class%"/>


See comment above.

UFOMelkor · 2017-01-09T17:38:21Z

composer.json

@@ -71,7 +73,7 @@
  "extra": {
    "branch-alias": {
      "dev-master": "1.0-dev",
-      "dev-develop": "1.1-dev"
+      "dev-prooph_v7": "0.3-dev"


As v0.3 has been released this should be 0.4-dev (or completely removed after finishing?)

I was a bit in struggle with these dependecies setup. Maybe the alias should be removed, true.

mablae · 2017-01-09T18:51:52Z

@UFOMelkor Thank you for the review, I will adjust the stuff.

prolic · 2017-02-17T12:13:48Z

composer.json

    "container-interop/container-interop": "^1.1"
  },
  "require-dev": {
    "phpunit/phpunit": "^5.3",
    "phpunit/php-invoker": "^1.1.4",
    "fabpot/php-cs-fixer": "^1.11",
    "bookdown/bookdown": "1.x-dev as 1.0.0",
-    "tobiju/bookdown-bootswatch-templates": "1.0.x-dev"
+    "tobiju/bookdown-bootswatch-templates": "^1.0",


prooph now has custom templates!

see: https://github.com/prooph/bookdown-template

Thanks, will apply that.

mablae · 2017-02-17T12:50:25Z

Ping @UFOMelkor , @codeliner , @prolic - Sorry I totally forgot about this branch.

I just did some updates. Travis passes now and the wrong branch alias also was removed.
Let me know if anything else is missing.

codeliner · 2017-02-19T21:51:06Z

thx @mablae

mablae force-pushed the prooph_v7 branch 2 times, most recently from 8a0a7bb to 34a0441 Compare January 3, 2017 21:37

mablae changed the title ~~Bump service bus package~~ WIP: Bump service bus package Jan 4, 2017

mablae force-pushed the prooph_v7 branch 3 times, most recently from 88fa39f to 89454cb Compare January 8, 2017 18:08

Update service-bus-bundle for ServiceBus v6.0

a71c7a3

- Introduce MessageBusFactory to control the reversed way of plugin attaching - Add onEvent and handle method to Fixture Model handlers and listeners - Test for factory - Use factory in abstract service definitions

mablae force-pushed the prooph_v7 branch from 89454cb to a71c7a3 Compare January 8, 2017 18:10

UFOMelkor reviewed Jan 9, 2017

View reviewed changes

mablae added 5 commits February 17, 2017 12:24

Fix CS

d8e7572

Remove branch alias

827e217

Fix Travis

88f24d8

Use stable service-bus version

7d2db30

Use stable tobiju/bookdown-bootswatch-templates

f39c7c1

prolic reviewed Feb 17, 2017

View reviewed changes

mablae added 4 commits February 17, 2017 13:25

Use prooph/bookdown-template

563da87

Declare bus factory definitions non-public

e445666

Replace sprintf() by string concat to be more consistent

caa56f3

Fix CS (removed empty line)

b7f97d6

codeliner approved these changes Feb 19, 2017

View reviewed changes

codeliner merged commit 0b483a1 into prooph:master Feb 19, 2017

codeliner mentioned this pull request Feb 19, 2017

Update to prooph Service Bus v6 #11

Closed

codeliner changed the title ~~WIP: Bump service bus package~~ Bump service bus package Feb 19, 2017

mablae deleted the prooph_v7 branch April 6, 2017 22:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump service bus package #10

Bump service bus package #10

mablae commented Jan 3, 2017 •

edited

Loading

codeliner commented Jan 4, 2017

codeliner commented Jan 4, 2017

mablae commented Jan 4, 2017 •

edited

Loading

prolic commented Jan 4, 2017

UFOMelkor commented Jan 4, 2017

prolic commented Jan 4, 2017 via email

prolic commented Jan 4, 2017

UFOMelkor commented Jan 4, 2017

mablae commented Jan 8, 2017

UFOMelkor left a comment

UFOMelkor Jan 9, 2017

UFOMelkor Jan 9, 2017

UFOMelkor Jan 9, 2017

UFOMelkor Jan 9, 2017

UFOMelkor Jan 9, 2017

UFOMelkor Jan 9, 2017

UFOMelkor Jan 9, 2017

UFOMelkor Jan 9, 2017

UFOMelkor Jan 9, 2017

UFOMelkor Jan 9, 2017 •

edited

Loading

mablae Jan 9, 2017

mablae commented Jan 9, 2017

prolic Feb 17, 2017

prolic Feb 17, 2017

mablae Feb 17, 2017

mablae commented Feb 17, 2017 •

edited

Loading

codeliner commented Feb 19, 2017

		$containerPluginId = 'prooph_service_bus.container_plugin';
		$pluginIds = array_filter(array_merge($options['plugins'], [$containerPluginId, $messageFactoryPluginId, $routerId]));

Bump service bus package #10

Bump service bus package #10

Conversation

mablae commented Jan 3, 2017 • edited Loading

codeliner commented Jan 4, 2017

codeliner commented Jan 4, 2017

mablae commented Jan 4, 2017 • edited Loading

prolic commented Jan 4, 2017

UFOMelkor commented Jan 4, 2017

prolic commented Jan 4, 2017 via email

prolic commented Jan 4, 2017

UFOMelkor commented Jan 4, 2017

mablae commented Jan 8, 2017

UFOMelkor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

UFOMelkor Jan 9, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mablae commented Jan 9, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mablae commented Feb 17, 2017 • edited Loading

codeliner commented Feb 19, 2017

mablae commented Jan 3, 2017 •

edited

Loading

mablae commented Jan 4, 2017 •

edited

Loading

UFOMelkor Jan 9, 2017 •

edited

Loading

mablae commented Feb 17, 2017 •

edited

Loading