Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageBusFactory cannot access private service #15

Merged
merged 2 commits into from
Apr 1, 2017

Conversation

lunetics
Copy link
Member

@lunetics lunetics commented Mar 28, 2017

In the MessageBusFactory the container is accessed via get().

 foreach ($plugins as $pluginId) {
            $plugin = $container->get($pluginId);
            $plugin->attachToMessageBus($bus);
        }

The prooph_service_bus.container_plugin is marked private,thus cannot be accessed. This PR removes the "public=false" attribute. Any specific reason to keep it private?

Same for message factory plugins and router plugins

In the MessageBusFactory the container is accessed via get(). The `prooph_service_bus.container_plugin` is marked private,thus cannot be accessed. Any specific reason to keep it private?
@lunetics lunetics requested a review from codeliner March 28, 2017 21:43
@lunetics lunetics added the bug label Mar 28, 2017
@codeliner
Copy link
Member

codeliner commented Mar 29, 2017

oh, it worked in the past. If I remember correctly the idea was to mark them as private services because they are only useful together with the message bus which should be the only public service. But looking at the sf docs again I think we need to make them public.
/cc @prooph/symfony-team

@lunetics lunetics merged commit b6436b2 into master Apr 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants