PHP 7.2 and Symfony ^4.0 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
php7.2 runs against highest dependencies, php7.1 against lowest
Some things need to be adjusted to get it working for symfony 4. - DataCollectorInterface has a reset-Method. - Services are private by default. This has to be adjusted mostly in tests. - ResolveDefinitionTemplatesPass is not available in v4.0, but ResolveChildDefinitionsPass is not available in 3.3 (tests only).
It is explicitly added to phpunit later and would slow down phpcs.
|
@UFOMelkor I suggest we test PHP 7.2 with highest AND lowest dependencies and PHP 7.1 also with highest AND lowest dependencies. This will make 4 travis builds and will take a little longer, but we are more safe like this. |
|
Changed it to:
|
mumia
reviewed
Dec 9, 2017
| class: ProophTest\Bundle\ServiceBus\DependencyInjection\Fixture\Model\AcmeUserEventListener | ||
| public: true |
There was a problem hiding this comment.
Thank you, I added one 👍
|
Any thoughts when this will be merged? |
|
ping @prooph/symfony-team |
codeliner
approved these changes
Dec 13, 2017
|
great job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On travis:
Some things need to be adjusted to get it working for symfony 4.
Closes #48
Closes #50