Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using the class name for handler services (in the documentation) #58

Merged
merged 2 commits into from
Jan 18, 2018

Conversation

@sstok
Copy link
Contributor

sstok commented Jan 17, 2018

Looks good to me 👍

@UFOMelkor
Copy link
Member

Thanks @coudenysj for your contribution 👍
Please remove the public attributes. While it's correct that they are currently necessary, the next release will not require them anymore. See #56 for more information.

@coudenysj
Copy link
Contributor Author

@UFOMelkor Done

@UFOMelkor UFOMelkor merged commit c1f211d into prooph:master Jan 18, 2018
@UFOMelkor
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants