Fix #603 #604
Closed
Fix #603 #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 15, 2013 00:47
TestSuite output:
$ phpunit test/testsuite/misc/MoreRelationTest.php
PHPUnit 3.7.13 by Sebastian Bergmann.
Configuration read from /Users/marc/Propel/phpunit.xml.dist
F
Time: 0 seconds, Memory: 18.75Mb
There was 1 failure:
1) MoreRelationTest::testContentsDeletion
We assigned a collection of only one item.
Failed asserting that 4 matches expected 1.
/Users/marc/Propel/test/testsuite/misc/MoreRelationTest.php:97
FAILURES!
Tests: 1, Assertions: 2, Failures: 1.
Added a test set that proves the bug.
|
Wait, please not merge yet. Have had a dream with another scenario where this fails too. Am trying to reproduce it later on the pc. |
| @@ -4090,11 +4104,13 @@ protected function addRefFkScheduledForDeletion(&$script, $refFK) | |||
| $queryClassName = $this->getNewStubQueryBuilder($refFK->getTable())->getClassname(); | |||
|
|
|||
| $localColumn = $refFK->getLocalColumn(); | |||
| $localColumn->isNotNull(); | |||
…ryKeys` at class ForeignKey and use it in the PHP5ObjectBuilder to check whether we have to backup the data of the relation entries to be able to manipulate it later. Added these methods because `isForeignPrimaryKey` returns only true if _all_ foreign columns are pks, which is not useful in this case.
| $this->assertEquals(1, $count, 'We assigned a collection of only one item.'); | ||
|
|
||
| } | ||
|
|
|
let me know when it's ok. |
added 2 commits
February 15, 2013 20:56
… proves that 'onDelete=setnull' works, too.
|
Done. |
|
Could you rebase? |
|
Hum, yeah, I meant "squash", not rebase... |
|
Sorry, destroyed my branch. Git rebase hates me ;o) Created a new PR. |
| */ | ||
| public function __clone() | ||
| { | ||
| foreach ($this as $key => $obj) { |
There was a problem hiding this comment.
Will this also make sense for the onDemand collections, or should this be overwritten and implemented differently for those? I would suppose a ondemand collection would hydrate all rows and therefore would no longer be lazy loaded,..?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anything is explained in #603