Fixed #603 #605
Merged
Fixed #603 #605
+309
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdurand
added a commit
that referenced
this pull request
Feb 15, 2013
|
thanks! |
| */ | ||
| public function __clone() | ||
| { | ||
| foreach ($this as $key => $obj) { |
There was a problem hiding this comment.
Will this also make sense for the onDemand collections, or should this be overwritten and implemented differently for those? I would suppose a ondemand collection would hydrate all rows and therefore would no longer be lazy loaded,..?
There was a problem hiding this comment.
prepared a PR to unit-test the new __clone() method... #610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Et voilà ! 🐇