Added parallel migrations

[mpscholten]

This is a port of propelorm/Propel#777 to Propel2, without the backwards compatibility. This feature is request in #145. Basically it's just tracking of all executed migrations instead of the latest one.

Only problem is that I'm unable to write tests. I need to call $migrationManager->setConnections(..) in the tests but I'm not sure where to get the connection settings from. If someone could help me with this, I'll try to write some tests.

I would really like to see this feature in Propel2 because it's really hard to use propel migrations if you have multiple feature branches.

[willdurand]

👍

[staabm]

please correct me if I am wrong: this PR removes the "old" way of doing migrations and does everything in parallel..?

propelorm/Propel#777 added the parallel part optionally (opt-in like approach)?

[willdurand]

Yep, because you are no more tied to the migrations' timestamps anymore, if I understand correctly.

[mpscholten]

added the parallel part optionally (opt-in like approach)?

Yes I dropped this because I think there's no benefit of keeping 2 ways of doing migrations.

[marcj]

Can you also write some tests for that?

[mpscholten]

I need to call $migrationManager->setConnections(..) in the tests but I'm not sure where to get the connection settings from. If someone could help me with this, I'll try to write some tests.

I tried already :-) but I don't know how to set up the MigrationManager object in my tests properly. I need to call setConnections after creating the new object, but I don't know where to get the connection informations in the test case.

[marcj]

Have you tried this way? https://github.com/propelorm/Propel2/blob/master/src/Propel/Generator/Command/MigrationMigrateCommand.php#L61

[mpscholten]

But where do I get the generator config? $generatorConfig->getBuildConnections($input->getOption('input-dir'));

[marcj]

$generatorConfig = new GeneratorConfig();

:-)

[mpscholten]

Thanks mate :) but $generatorConfig->getBuildConnections() is an empty array now

[marcj]

Yes, because you have to pass a directory of a fixture you want to use.

$generatorConfig->getBuildConnections(__DIR__. '/../../path/to/tests/Fixtures/migration/');

[mpscholten]

Thanks, tests are ready now. Time for review

[gharlan]

Hmm, all SQLite builds failed..

[mpscholten]

Fixed. Maybe later we can port the tests back to propel1 so we can merge propelorm/Propel#777

[mpscholten]

Any updates here? :-)

[willdurand]

LGTM @marcj

[jaugustin]

it's ok for me to,
@willdurand could you merge this PR ?
I am working on a new migration command and some improvement and it would be better if I could use this ;)

[willdurand]

it needs to be rebased.

[mpscholten]

Rebase done

[marcj]

Squash please :)

[mpscholten]

Squashed

[marcj]

Good job 👯