Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tag on wrong commit, #254 create working Dockerfile + CI #257

Merged
merged 4 commits into from
Oct 10, 2024
Merged

fix tag on wrong commit, #254 create working Dockerfile + CI #257

merged 4 commits into from
Oct 10, 2024

Conversation

SIMULATAN
Copy link
Collaborator

ATM, a new Dockerfile is implemented. I will add a Docker CI soon.

@jonasfroeller jonasfroeller added this to the Stable milestone Sep 28, 2024
@jonasfroeller jonasfroeller added the sprint-08 sprint info label Sep 28, 2024
@jonasfroeller jonasfroeller marked this pull request as ready for review October 3, 2024 09:13
jonasfroeller
jonasfroeller approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@jonasfroeller jonasfroeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SIMULATAN SIMULATAN changed the title #254 create working Dockerfile + CI fix tag on wrong commit, #254 create working Dockerfile + CI Oct 10, 2024
@SIMULATAN SIMULATAN merged commit 76ee00b into main Oct 10, 2024
1 check passed
@SIMULATAN SIMULATAN deleted the docker-ci branch October 10, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasfroeller jonasfroeller jonasfroeller approved these changes

@stevan06v stevan06v Awaiting requested review from stevan06v

Assignees
No one assigned
Labels
sprint-08 sprint info
Projects
propromo.web
Status: Done
Milestone
Stable
Development

Successfully merging this pull request may close these issues.
2 participants
@SIMULATAN @jonasfroeller