Implement #[proptest(regex = "...")] #103

Centril · 2018-11-01T22:42:01Z

This PR implements #[proptest(regex = "...")].

To do so cleanly, the trait StrategyFromRegex is introduced into proptest::string but is hidden and semver exempt.
The PR improves some of the error messages.
New error messages E0034 (reports malformed regex attribute modifiers), E0035 (reports params and regex used on the same field together which is nonsense since the params can't be used inside the regex string...).
Some minor refactoring is done.
Some missing test coverage is made up for.

…st(regex..)]

…rsing.

AltSysrq · 2018-11-04T21:19:16Z

Thanks again!

Centril added 15 commits November 1, 2018 16:29

provide internal API proptest::string::StrategyFromRegex for #[propte…

ed5caa9

…st(regex..)]

proptest-derive: error.rs -- improve messages + regex related errors.

0a61b1f

proptest-derive: attr.rs -- cleanup + support #[proptest(regex..)] pa…

b017c1c

…rsing.

proptest-derive: derive.rs -- refactor + lowering logic for regex.

27b273f

proptest-derive: ast.rs -- implement regex in abstract syntax.

24e21b6

proptest-derive: E0025: extend to regex.

c5bbde7

proptest-derive: E0007: extend to regex + value.

c83a037

proptest-derive: E0029: extend to regex.

37df24a

proptest-derive: add E0034-regex-malformed.

c2a36a6

proptest-derive: add E0035 tests.

367d904

proptest-derive: simplify StrategyFromRegex.

81c287c

proptest-derive: derive.rs -- refactor.

963f10a

proptest-derive: test: regex_wrong_type.

6035e3b

proptest-derive: ensure that #[proptest(regex...)] behaves as expected.

210ba4d

proptest-derive: ensure that #[proptest(regex = r...)] works.

a2c97b4

This was referenced Nov 1, 2018

Tracking issue for proptest_derive #102

Closed

Proptest-derive book #104

Merged

AltSysrq merged commit cba44e4 into proptest-rs:proptest-derive Nov 4, 2018

Centril deleted the derive/regex branch November 4, 2018 21:19

Provide feedback