Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the nightly requirement for lazy_static on no_std #112

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

nivkner
Copy link
Contributor

@nivkner nivkner commented Dec 13, 2018

thanks to rust-lang-nursery/lazy-static.rs#130, lazy-static now works on stable with no_std

@Eh2406
Copy link

Eh2406 commented Dec 15, 2018

I believe removing a feature is a break-in change.

@nivkner
Copy link
Contributor Author

nivkner commented Dec 15, 2018

yeah, I guess it is.
removed the commit, but since the nightly feature was only used for this,
it should be removed for 0.9

@AltSysrq
Copy link
Collaborator

Thanks for this!

0.9 is going to be the next version anyway, but I think it makes sense to keep the nightly feature since we may be adding stuff to it in the future again.

@nivkner
Copy link
Contributor Author

nivkner commented Dec 30, 2018

@AltSysrq is there a reason why this PR did not get merged?
since as previously stated I removed the feature removing commit, this only removes its use for lazy_static.

@Centril
Copy link
Collaborator

Centril commented Dec 30, 2018

@AltSysrq We have an unstable feature, so we should remove nightly in favor of that one (unstable is the standard name in the ecosystem).

@AltSysrq
Copy link
Collaborator

@nivkner I haven't had time to work on the next release yet, and I don't like things being in "merged/closed but not actually available for use". I'm planning on working on this next weekend so it will probably be merged then.

@AltSysrq AltSysrq mentioned this pull request Dec 31, 2018
@AltSysrq AltSysrq merged commit f36b3db into proptest-rs:master Feb 4, 2019
@AltSysrq
Copy link
Collaborator

AltSysrq commented Feb 4, 2019

This has been incorporated into 0.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants