[fix-ci-nigtly] #285
Merged
[fix-ci-nigtly] #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rex-remind101
requested review from
seanmajorpayne,
matthew-russo and
cameron1024
…orrect it * dependencies.x86 was bumped to latest current version. x86 crate does not advertise an MSRV, but this was just broken on even our MSRV because the old x86 version was using a macro removed from rust, so bumping to latest seems fair. * the calculation for the arbitrary impl of Layout was using a max_size that was too large and overflowing Layout. this has been fixed. * test for arbitrary AllocError was referring to AllocErr which does not exist, this was fixed. * NoneError has been removed from rust so it was subsequently removed from proptest. It was blocking compilation. evidence: rust-lang/rust#85614 * try_reserve is stable so removed from unstable features * try_trait has been changed to try_trait_v2 so that was fixed in Cargo.toml.
rex-remind101
force-pushed
the
fix-ci-nightly
branch
from
9ea1f42
to
6a958db
Compare
cameron1024
approved these changes
Dec 19, 2022
matthew-russo
approved these changes
Dec 19, 2022
rex-remind101
force-pushed
the
fix-ci-nightly
branch
3 times, most recently
from
3ab6eac
to
b6212c9
Compare
rex-remind101
force-pushed
the
fix-ci-nightly
branch
from
b6212c9
to
1ccc872
Compare
|
Hi, just fyi, this PR can close also #266 |
|
fyi, we're still trying to piece together why this last compiletest is failing. |
matthew-russo
approved these changes
Dec 20, 2022
…also correct random grammar error
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci was broken on nightly this series of fixes should correct it
NoneErrorin modulestd::optionrust-lang/rust#85614