Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo and update URLs in docs #236

Merged
merged 1 commit into from
May 26, 2018
Merged

Fix typo and update URLs in docs #236

merged 1 commit into from
May 26, 2018

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Sep 17, 2017

@coveralls
Copy link

coveralls commented Sep 17, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 58.635% when pulling 5914ac4 on tnir:235-docs-typo into c9122a8 on landscapeio:master.

chocoelho
chocoelho suggested changes May 25, 2018
View reviewed changes
Copy link
Contributor

@chocoelho chocoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Please, just resolve the conflict and I'll merge.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 583

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 76.993%
Files with Coverage Reduction New Missed Lines %
prospector/config/init.py 1 79.68%
prospector/tools/utils.py 2 82.76%
prospector/run.py 7 71.43%
Totals Coverage Status
Change from base Build 581: -0.2%
Covered Lines: 1449
Relevant Lines: 1882
💛 - Coveralls

@coveralls
Copy link

coveralls commented May 26, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 583

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 77.099%
Files with Coverage Reduction New Missed Lines %
prospector/config/init.py 1 80.21%
prospector/tools/utils.py 2 89.66%
prospector/run.py 7 78.1%
Totals Coverage Status
Change from base Build 581: -0.1%
Covered Lines: 1451
Relevant Lines: 1882
💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 583

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 77.099%
Files with Coverage Reduction New Missed Lines %
prospector/config/init.py 1 80.21%
prospector/tools/utils.py 2 89.66%
prospector/run.py 7 78.1%
Totals Coverage Status
Change from base Build 581: -0.1%
Covered Lines: 1451
Relevant Lines: 1882
💛 - Coveralls

@coveralls
Copy link

coveralls commented May 26, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 583

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 77.099%
Files with Coverage Reduction New Missed Lines %
prospector/config/init.py 1 80.21%
prospector/tools/utils.py 2 89.66%
prospector/run.py 7 78.1%
Totals Coverage Status
Change from base Build 581: -0.1%
Covered Lines: 1451
Relevant Lines: 1882
💛 - Coveralls

@tnir
Copy link
Contributor Author

tnir commented May 26, 2018

@chocoelho Thanks for the review. I just rebased this against master. CI failure by coveralls is not intrinsic in this PR.

@chocoelho
Copy link
Contributor

Great, thanks!

@chocoelho chocoelho merged commit c914dfb into prospector-dev:master May 26, 2018
@tnir tnir deleted the 235-docs-typo branch May 26, 2018 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chocoelho chocoelho chocoelho requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnir @coveralls @chocoelho