Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify astroid<2.0 to avoid pre-releases #17

Closed

Conversation

tnir
Copy link
Contributor

@tnir tnir commented May 26, 2018

To work well with the spec of setuptools, the existence of pre-released astroid==2.0.0.dev0, and the packages with 'astroid<2.0' (e.g., pylint), this PR fixes that problem.

Closes #16

@coveralls
Copy link

coveralls commented May 26, 2018

Coverage Status

Coverage remained the same at 70.909% when pulling 0fa72c1 on tnir:16-astroid-2.0-for-setuptools into 4227233 on landscapeio:master.

@tnir
Copy link
Contributor Author

tnir commented May 28, 2018

@carlio

@carlio
Copy link
Member

carlio commented Jul 22, 2018

Now that 2.0 has been released I instead just fixed it to be compatible. requirements-detector 0.6 has the required changes. Thanks for the PR ,sorry it took too long to do anything about it!

@carlio carlio closed this Jul 22, 2018
@tnir tnir deleted the 16-astroid-2.0-for-setuptools branch August 22, 2018 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify astroid<2.0 for setuptools
3 participants