-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update errors field in JSON Report #108
Conversation
modelscan/tools/picklescanner.py
Outdated
[], [ModelScanError("pytorch", f"Invalid magic number for file {source}")] | ||
[], | ||
[ | ||
ModelScanError( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking this should be a skipped reason instead of an error. In the benchmarking we're encountering .bin files that aren't pytorch and we should just be skipping them instead of erroring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @swashko for sharing this! I have now updated it to add them to skipped files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some small style things, in general lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates
errors
andskipped
field to have acategory
,description
andsource
(optional forerror
) field for JSON reporting as outlined in #107.Close #107
Sample result for a h5 model that does not have a model config:
Sample results for a dependency error: