Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enums are case sensitive #17

Closed
milesjos opened this issue Mar 31, 2023 · 0 comments · Fixed by #18
Closed

Enums are case sensitive #17

milesjos opened this issue Mar 31, 2023 · 0 comments · Fixed by #18
Assignees
@cherbel
Labels
bug Something isn't working

Comments

@milesjos
Copy link
Member

Describe the bug
Right now the settings that use enums (licenses_for_notebooks_source, redact_secret) are case-sensitive.

To Reproduce
Steps to reproduce the behavior:

  1. Set the redact_secret value to partial
  2. Run a scan
  3. An unknown scan setting error will appear

Expected behavior
These should be valid values for these settings.

Desktop (please complete the following information):

  • OS: MacOS
  • Version: 1.0.2
@milesjos milesjos added the bug Something isn't working label Mar 31, 2023
@cherbel cherbel self-assigned this Mar 31, 2023
@cherbel cherbel linked a pull request Mar 31, 2023 that will close this issue
Remove Case Sensitivity for Enum Settings #18
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cherbel cherbel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Case Sensitivity for Enum Settings protectai/nbdefense
2 participants
@milesjos @cherbel