Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Case Sensitivity for Enum Settings #18

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Remove Case Sensitivity for Enum Settings #18

merged 2 commits into from
Mar 31, 2023

Conversation

cherbel
Copy link
Member

@cherbel cherbel commented Mar 31, 2023 •
edited
Loading

  • Fixes enums settings case sensitivity issues (redact_secret, and licenses_for_notebooks_source are no longer case sensitive)
  • Adds UnknownSettingsValueError Exceptions

@cherbel cherbel requested a review from milesjos March 31, 2023 19:26
@cherbel cherbel self-assigned this Mar 31, 2023
@cherbel cherbel linked an issue Mar 31, 2023 that may be closed by this pull request
Enums are case sensitive #17
Closed
@cherbel cherbel marked this pull request as ready for review March 31, 2023 19:30
milesjos
milesjos approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@milesjos milesjos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@cherbel cherbel merged commit d9cd661 into main Mar 31, 2023
@cherbel cherbel deleted the 17-settings-case branch March 31, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milesjos milesjos milesjos approved these changes

Assignees

@cherbel cherbel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enums are case sensitive
2 participants
@cherbel @milesjos