Other: Exclude dist/ from codeclimate checks

.codeclimate.yml

@@ -1,3 +1,4 @@
+---
 engines:
   eslint:
     enabled: true
@@ -13,6 +14,8 @@ ratings:
   - "lib/path/**.js"
   - "lib/pool/**.js"
   - "lib/utf8/**.js"
+  - "**.md"
 exclude_paths:
+  - "dist/**"
   - "**/tests/**"
   - "cli/wrappers/**"

.eslintignore

@@ -1,4 +1,3 @@
-bench/*
 bin/*
 cli/wrappers/*
 coverage/*
@@ -12,5 +11,4 @@ lib/tape-adapter.js
 lib/tsd-jsdoc/*
 lib/*/tests/*
 sandbox/*
-scripts/*
 tests/*

README.md

@@ -137,7 +137,7 @@ protobuf.load("awesome.proto", function(err, root) {
 
 * `Message.encode` does not implicitly verify a message but tries to encode whatever is specified, possibly resulting in a runtime error being thrown somewhere down the road.
 * `Message.verify` can be used to explicitly perform verification prior to encoding where necessary. Instead of throwing, it returns the error message, if any.
-* `Message.decode` throws if a buffer is invalid or missing required fields and doesn't require calling `Message.verify` afterwards.
+* `Message.decode` throws if a buffer is invalid or missing required fields (a `protobuf.util.ProtocolError` with an `instance` property set to the so far decoded message in the latter case) and doesn't require calling `Message.verify` afterwards.
 
 Additionally, promise syntax can be used by omitting the callback, if preferred:
 

cli/pbjs.js

@@ -108,7 +108,8 @@ exports.main = function main(args, callback) {
                 "  --no-beautify   Does not beautify generated code.",
                 "  --no-comments   Does not output any JSDoc comments.",
                 "",
-                "usage: " + chalk.bold.green("pbjs") + " [options] file1.proto file2.json ..." + chalk.gray("  (or)  ") + "other | " + chalk.bold.green("pbjs") + " [options] -"
+                "usage: " + chalk.bold.green("pbjs") + " [options] file1.proto file2.json ..." + chalk.gray("  (or)  ") + "other | " + chalk.bold.green("pbjs") + " [options] -",
+                ""
             ].join("\n"));
         return 1;
     }

cli/pbts.js

@@ -57,7 +57,8 @@ exports.main = function(args, callback) {
                 "",
                 "  -m, --main      Whether building the main library without any imports.",
                 "",
-                "usage: " + chalk.bold.green("pbts") + " [options] file1.js file2.js ..." + chalk.bold.gray("  (or)  ") + "other | " + chalk.bold.green("pbts") + " [options] -"
+                "usage: " + chalk.bold.green("pbts") + " [options] file1.js file2.js ..." + chalk.bold.gray("  (or)  ") + "other | " + chalk.bold.green("pbts") + " [options] -",
+                ""
             ].join("\n"));
         return 1;
     }

cli/targets/proto.js

@@ -68,6 +68,8 @@ function push(line) {
 
 function escape(str) {
     return str.replace(/[\\"']/g, "\\$&")
+              .replace(/\r/g, "\\r")
+              .replace(/\n/g, "\\n")
               .replace(/\u0000/g, "\\0");
 }
 
@@ -150,13 +152,17 @@ function buildEnum(enm) {
 
 function buildRanges(keyword, ranges) {
     if (ranges && ranges.length) {
-        push("");
+        var parts = [];
         ranges.forEach(function(range) {
-            if (range[0] === range[1])
-                push(keyword + " " + range[0] + ";");
+            if (typeof range === "string")
+                parts.push("\"" + escape(range) + "\"");
+            else if (range[0] === range[1])
+                parts.push(range[0]);
             else
-                push(keyword + " " + range[0] + " to " + (range[1] === 0x1FFFFFFF ? "max" : range[1]) + ";");
+                parts.push(range[0] + " to " + (range[1] === 0x1FFFFFFF ? "max" : range[1]));
         });
+        push("");
+        push(keyword + " " + parts.join(", "));
     }
 }
 
@@ -178,7 +184,7 @@ function buildType(type) {
 }
 
 function buildField(field, passExtend) {
-    if (field.partOf || field.declaringField || !(field.extend === undefined || passExtend))
+    if (field.partOf || field.declaringField || field.extend !== undefined && !passExtend)
         return;
     if (first) {
         first = false;

cli/targets/static.js

@@ -18,7 +18,7 @@ var out = [];
 var indent = 0;
 var config = {};
 
-static_target.description = "Static code without reflection";
+static_target.description = "Static code without reflection (non-functional on its own)";
 
 function static_target(root, options, callback) {
     config = options;

scripts/bundle.js

@@ -1,5 +1,8 @@
+"use strict";
 module.exports = bundle;
-var fs         = require("fs");
+
+var fs         = require("fs"),
+    path       = require("path");
 
 var browserify = require("browserify");
 
@@ -15,8 +18,9 @@ var source     = require("vinyl-source-stream");
 
 var zopfli     = require("node-zopfli");
 
-var pkg = require(__dirname + "/../package.json");
+var pkg = require(path.join(__dirname, "..", "package.json"));
 
+/*eslint-disable no-template-curly-in-string*/
 var license = [
     "/*!",
     " * protobuf.js v${version} (c) 2016, Daniel Wirtz",
@@ -25,6 +29,7 @@ var license = [
     " * see: https://github.com/dcodeIO/protobuf.js for details",
     " */"
 ].join("\n") + "\n";
+/*eslint-enable no-template-curly-in-string*/
 
 var prelude = fs.readFileSync(require.resolve("../lib/prelude.js")).toString("utf8");
 
@@ -35,6 +40,7 @@ var prelude = fs.readFileSync(require.resolve("../lib/prelude.js")).toString("ut
  * @param {string} options.target Target directory
  * @param {boolean} [options.compress=false] Whether to minify or not
  * @param {string[]} [options.exclude] Excluded source files
+ * @returns {undefined}
  */
 function bundle(options) {
     if (!options || !options.entry || !options.target)
@@ -93,6 +99,7 @@ function bundle(options) {
  * @param {string} sourceFile Source file
  * @param {string} destinationFile Destination file
  * @param {function(?Error)} callback Node-style callback
+ * @returns {undefined}
  */
 bundle.compress = function compress(sourceFile, destinationFile, callback) {
     var src = fs.createReadStream(sourceFile);

scripts/changelog.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var path = require("path"),
     fs   = require("fs");
 
@@ -76,7 +78,7 @@ gitSemverTags(function(err, tags) {
             hash = match[1];
         }
         message.split(";").forEach(function(message) {
-            if (/^(Merge pull request |Post\-merge)/.test(message))
+            if (/^(Merge pull request |Post-merge)/.test(message))
                 return;
             var match = /^(\w+):/i.exec(message = message.trim());
             var category;

scripts/gentests.js

@@ -31,7 +31,7 @@ var fs   = require("fs"),
         } catch (err2) {
             process.stderr.write("ERROR: " + err2.message + "\n");
         }
-    })
+    });
 });
 
 [

scripts/pages.js

@@ -1,3 +1,6 @@
+/*eslint-disable no-console*/
+"use strict";
+
 var ghpages = require("gh-pages"),
     path    = require("path");
 

scripts/postinstall.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var path = require("path"),
     fs   = require("fs"),
     pkg  = require(path.join(__dirname, "..", "package.json"));

scripts/prepublish.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var path = require("path"),
     fs   = require("fs");