Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 error should be thrown #1817

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

binsee
Copy link
Contributor

@binsee binsee commented Sep 23, 2022

fix #1816

@alexander-fenster alexander-fenster self-requested a review January 24, 2023 19:07
@alexander-fenster alexander-fenster merged commit e7a3489 into protobufjs:master Jan 24, 2023
@github-actions github-actions bot mentioned this pull request Jan 24, 2023
bcoe added a commit to googleapis/nodejs-proto-files that referenced this pull request Jan 31, 2023
bcoe added a commit to googleapis/nodejs-proto-files that referenced this pull request Jan 31, 2023
alexander-fenster added a commit that referenced this pull request Feb 2, 2023
alexander-fenster added a commit that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pbjs will not display error messages in some cases
2 participants