use docker:generic runner, and run ldconfig at the end #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
commented
Oct 27, 2020
| # SDK_DIR is the location containing the (optional) sdk source inside the container. | ||
| ENV SDK_DIR /sdk | ||
|
|
||
| # Install brotli |
There was a problem hiding this comment.
Installing brotli before any other code (such as COPY . /) that would invalidate the docker cache. We don't want to install this multiple times.
nonsense
commented
Oct 27, 2020
|
|
||
| RUN mv ${PLAN_DIR}/testplan.bin /testplan | ||
|
|
||
| RUN ldconfig |
There was a problem hiding this comment.
ldconfig adds links and cache to the most recent shared libraries... not sure why the brotli libraries are not found without it, haven't really read the documentation for brotli...
nonsense
commented
Oct 27, 2020
| push_registry=true | ||
| go_proxy_mode="remote" | ||
| go_proxy_url="http://localhost:8081" | ||
| registry_type="aws" |
There was a problem hiding this comment.
No need for the skip_runtime_image here anymore, as we are using the docker:generic builder, and we specify a concrete Dockerfile for our test plan.
nonsense
commented
Oct 27, 2020
| [[groups]] | ||
| id = "nodes" | ||
| instances = { count = 6 } | ||
|
|
There was a problem hiding this comment.
I've removed the dependencies from the other composition file, since they don't compile - I guess they are outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding 2 compositions that use the
docker:genericbuilder - one forlocal:dockerand one forcluster:k8s.