Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong bundle version in Java pom! #14

Closed
protobufel opened this issue Sep 4, 2014 · 7 comments
Closed

Wrong bundle version in Java pom! #14

protobufel opened this issue Sep 4, 2014 · 7 comments
Labels
bug
Milestone
Release 2.6.1

Comments

@protobufel
Copy link

The distribution protobuf-2.6.0.zip (download from the site) has java/pom.xml which in line 151 specifies
wrong version, 2.5.0! And here is the line:
com.google.protobuf;version=2.5.0
IMHO, this is a major bug!

Cheers,
David
@xfxyjwf
Copy link
Contributor

xfxyjwf commented Sep 4, 2014

Sorry about that. How bad is this issue? Does it cause projects to fail to build/deploy or something? I just uploaded 2.6.0 release package to maven central repository without realizing this. Depending on how serious the problem is we probably need a minor release to fix it.

@protobufel
Copy link
Author

It must be significant for OSGI uses, for others it's not.

@xfxyjwf xfxyjwf added this to the Release 2.6.1 milestone Sep 10, 2014
@xfxyjwf xfxyjwf added the bug label Sep 10, 2014
@domthewop
Copy link

This is resolved as of the current version of the code.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Oct 21, 2014

I have updated the version number to 2.6.1 in the 2.6.1 release branch:
https://github.com/google/protobuf/blob/2.6.1/java/pom.xml

That will be pom.xml file we'll push to maven central repository.

@xfxyjwf xfxyjwf closed this as completed Oct 21, 2014
@protobufel
Copy link
Author

Is it possible to release 2.6.1 RC or final ASAP on Maven? The 2.6.0 in Java is a complete no-go!

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Oct 21, 2014

Hi David,
I just published 2.6.1. Can you help verify whether the pom.xml is correct? I'll upload it to Maven soon.

@protobufel
Copy link
Author

Verified; it's alright! There are some insignificant JavaDoc warnings,
that's okay to address in the next minor release, don't worry about them.
I'll file an issue about this soon.

All in all, it's fine for release on Maven! Please do it ASAP! My project
is very much depends on the release!

Cordially,
David

On Tue, Oct 21, 2014 at 4:24 PM, Feng Xiao notifications@github.com wrote:

Hi David,
I just published 2.6.1. Can you help verify whether the pom.xml is
correct? I'll upload it to Maven soon.

—
Reply to this email directly or view it on GitHub
#14 (comment).

@cloudkey cloudkey mentioned this issue Feb 4, 2015
Closed
@jakiechris jakiechris mentioned this issue Nov 20, 2017
Closed
@gatkinso gatkinso mentioned this issue Nov 23, 2017
Closed
@E-HERO E-HERO mentioned this issue Dec 3, 2017
Closed
@ujmedia ujmedia mentioned this issue Jul 23, 2018
Closed
@catskul catskul mentioned this issue Aug 21, 2018
Closed
@arnow117 arnow117 mentioned this issue Apr 1, 2019
Closed
@sunbibei sunbibei mentioned this issue Sep 26, 2019
Closed
@snehasinha13 snehasinha13 mentioned this issue Sep 30, 2020
Closed
@xianggao xianggao mentioned this issue Oct 27, 2021
Closed
@sin-zx sin-zx mentioned this issue Jan 18, 2022
Closed
@rong-lai rong-lai mentioned this issue Jul 25, 2023
Closed
rinarakaki pushed a commit to rinarakaki/protobuf that referenced this issue Aug 30, 2023
@haberman @copybara-github
Fixed MSAN warning by freeing the arena in ~InlinedArena().
81d27ec 
This fixes an MSAN warning of the form:

```
WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x7fc964f2a597 in arena_findroot third_party/upb/upb/mem/arena.c:64:3
    #1 0x7fc964f2a597 in upb_Arena_Free third_party/upb/upb/mem/arena.c:211:7
    protocolbuffers#2 0x7fc9d2af0028 in std::__msan::unique_ptr<upb_Arena, void (*)(upb_Arena*)>::~unique_ptr() third_party/crosstool/v18/stable/toolchain/bin/../include/c++/v1/__memory/unique_ptr.h:277:7
    protocolbuffers#3 0x7fc9d2aef7a2 in ~Arena third_party/upb/upb/upb.hpp:70:7
    protocolbuffers#4 0x7fc9d2aef7a2 in ~InlinedArena third_party/upb/upb/upb.hpp:97:7
    protocolbuffers#5 0x7fc9d2aef7a2 in Cpp_InlinedArena2_Test::TestBody() third_party/upb/upb/test/test_cpp.cc:187:1
    protocolbuffers#6 0x7fc97da78a57 in testing::Test::Run() third_party/googletest/googletest/src/gtest.cc:2695:5
    protocolbuffers#7 0x7fc97da7a3e8 in testing::TestInfo::Run() third_party/googletest/googletest/src/gtest.cc:2844:11
    protocolbuffers#8 0x7fc97da7b897 in testing::TestSuite::Run() third_party/googletest/googletest/src/gtest.cc:3003:30
    protocolbuffers#9 0x7fc97daa5136 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/googletest/src/gtest.cc:5899:44
    protocolbuffers#10 0x7fc97daa455c in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/googletest/src/gtest.cc
    protocolbuffers#11 0x7fc97daa455c in testing::UnitTest::Run() third_party/googletest/googletest/src/gtest.cc:5464:10
    protocolbuffers#12 0x562a7fb876f0 in RUN_ALL_TESTS third_party/googletest/googletest/include/gtest/gtest.h:2329:73
    protocolbuffers#13 0x562a7fb876f0 in main testing/base/internal/gunit_main.cc:86:10
    protocolbuffers#14 0x7fc9ba9b7632 in __libc_start_main (/usr/grte/v5/lib64/libc.so.6+0x61632) (BuildId: 280088eab084c30a3992a9bce5c35b44)
    protocolbuffers#15 0x562a7fafdbe9 in _start /build/work/ab393f4ac612f9027aae6b1a7226027ba2a2/google3/blaze-out/k8-opt/bin/third_party/grte/v5_src/grte-scratch/BUILD/src/csu/../sysdeps/x86_64/start.S:120

  Member fields were destroyed
    #0 0x562a7fb0b13d in __sanitizer_dtor_callback_fields third_party/llvm/llvm-project/compiler-rt/lib/msan/msan_interceptors.cpp:960:5
    #1 0x7fc9d2aef79a in ~InlinedArena third_party/upb/upb/upb.hpp:105:8
    protocolbuffers#2 0x7fc9d2aef79a in ~InlinedArena third_party/upb/upb/upb.hpp:97:7
    protocolbuffers#3 0x7fc9d2aef79a in Cpp_InlinedArena2_Test::TestBody() third_party/upb/upb/test/test_cpp.cc:187:1
    protocolbuffers#4 0x7fc97da78a57 in testing::Test::Run() third_party/googletest/googletest/src/gtest.cc:2695:5
    protocolbuffers#5 0x7fc97da7a3e8 in testing::TestInfo::Run() third_party/googletest/googletest/src/gtest.cc:2844:11
    protocolbuffers#6 0x7fc97da7b897 in testing::TestSuite::Run() third_party/googletest/googletest/src/gtest.cc:3003:30
    protocolbuffers#7 0x7fc97daa5136 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/googletest/src/gtest.cc:5899:44
    protocolbuffers#8 0x7fc97daa455c in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> third_party/googletest/googletest/src/gtest.cc
    protocolbuffers#9 0x7fc97daa455c in testing::UnitTest::Run() third_party/googletest/googletest/src/gtest.cc:5464:10
    protocolbuffers#10 0x562a7fb876f0 in RUN_ALL_TESTS third_party/googletest/googletest/include/gtest/gtest.h:2329:73
    protocolbuffers#11 0x562a7fb876f0 in main testing/base/internal/gunit_main.cc:86:10
    protocolbuffers#12 0x7fc9ba9b7632 in __libc_start_main (/usr/grte/v5/lib64/libc.so.6+0x61632) (BuildId: 280088eab084c30a3992a9bce5c35b44)
    protocolbuffers#13 0x562a7fafdbe9 in _start /build/work/ab393f4ac612f9027aae6b1a7226027ba2a2/google3/blaze-out/k8-opt/bin/third_party/grte/v5_src/grte-scratch/BUILD/src/csu/../sysdeps/x86_64/start.S:120
```

PiperOrigin-RevId: 511849224
GerHobbelt pushed a commit to GerHobbelt/protobuf that referenced this issue Aug 4, 2024
@mfpdias
Merge pull request protocolbuffers#14 from Esri/marc9905/anno318_prot…
86a5218 
…obuf_update_3_11_b

Marc9905/anno318 protobuf update 3 11 b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Release 2.6.1
Development

No branches or pull requests
3 participants
@domthewop @protobufel @xfxyjwf