Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add public modifier to generated kotlin code #10598

Closed
wants to merge 1 commit into from
Closed

Add public modifier to generated kotlin code #10598

wants to merge 1 commit into from

Conversation

STAR-ZERO
Copy link
Contributor

fix #10593
Add public modifier to generated kotlin code for Explicit API mode compatible.

@STAR-ZERO
Copy link
Contributor Author

Let me close.
#10599 was merged.

@STAR-ZERO STAR-ZERO closed this Sep 17, 2022
alexander-yevsyukov added a commit to SpineEventEngine/base that referenced this pull request Nov 23, 2022
@alexander-yevsyukov
Revert Protobuf back to 3.19.6
631f18a 
These don't seem to work for us:

protocolbuffers/protobuf#10598

protocolbuffers/protobuf#10593

protocolbuffers/protobuf#8857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deannagarcia deannagarcia Awaiting requested review from deannagarcia

Assignees
No one assigned
Labels
kotlin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Degrade: Kotlin explicit api mode
3 participants
@STAR-ZERO @acozzette @protobuf-kokoro