Expect fail when serialize inf and nan for Value.number_value in json format. fixes #11259 #11376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_496741357
branch
2 times, most recently
from
84b73aa to
26a941d
Compare
copybara-service
bot
force-pushed
the
test_496741357
branch
3 times, most recently
from
51298a0 to
2bfedf9
Compare
copybara-service
bot
force-pushed
the
test_496741357
branch
from
2bfedf9 to
22a92c6
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_496741357
branch
from
22a92c6 to
0dc2016
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_496741357
branch
from
0dc2016 to
bf81e36
Compare
copybara-service
bot
force-pushed
the
test_496741357
branch
from
bf81e36 to
c105e85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expect fail when serialize inf and nan for Value.number_value in json format. fixes #11259
Implemented in java, c++, python and upb. Also added conformance test.
https://developers.google.com/protocol-buffers/docs/reference/google.protobuf#google.protobuf.Value
where it says:
attempting to serialize NaN or Infinity results in error. (We can't serialize these as string "NaN" or "Infinity" values like we do for regular fields, because they would parse as string_value, not number_value).