Backport MSVC 32-bit fix #13656
Merged
Backport MSVC 32-bit fix #13656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 559192056
Disable the alignment check in 32-bit msvc. This toolchain has a difference between "natural" and "required" alignment of types and it can have the alignment of members of type `T` to be smaller than `alignof(T)`. Also, disable AnyTest.TestPackFromSerializationExceedsSizeLimit there because it can't allocate that much memory. PiperOrigin-RevId: 559495544
Backport MSVC 32-bit fix
mkruskal-google
requested review from
haberman and
zhangskz
and removed request for
a team
zhangskz
approved these changes
Aug 23, 2023
PiperOrigin-RevId: 558844591
zhangskz
approved these changes
Aug 23, 2023
fowles
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles a known alignment bug in MSVC and adds tests to cover the environment