Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#ifdef out clang-specific pragmas to avoid unknown pragma warnings when compiling with non-clang #18241

Closed
wants to merge 1 commit into from
Closed

#ifdef out clang-specific pragmas to avoid unknown pragma warnings when compiling with non-clang #18241

wants to merge 1 commit into from

Conversation

tempoz
Copy link
Contributor

@tempoz tempoz commented Sep 11, 2024

No description provided.

@tempoz tempoz requested a review from a team as a code owner September 11, 2024 13:53
@tempoz tempoz requested review from sbenzaquen and removed request for a team September 11, 2024 13:53
@tonyliaoss tonyliaoss added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Sep 17, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Sep 17, 2024
@tonyliaoss tonyliaoss added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Sep 19, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Sep 19, 2024
@tonyliaoss
Copy link
Member

Integration tests are failing due to version skew -- gonna force-pull this one.

copybara-service bot pushed a commit that referenced this pull request Sep 19, 2024
@tempoz @copybara-github
#ifdef out clang-specific pragmas to avoid unknown pragma warning…
da2e3c2 
…s when compiling with non-`clang` (#18241)

Closes #18241

COPYBARA_INTEGRATE_REVIEW=#18241 from tempoz:tempoz-fix-unknown-pragma e67f358
FUTURE_COPYBARA_INTEGRATE_REVIEW=#18241 from tempoz:tempoz-fix-unknown-pragma e67f358
PiperOrigin-RevId: 676539982
@copybara-service copybara-service bot mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbenzaquen sbenzaquen sbenzaquen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tempoz @tonyliaoss @sbenzaquen @mkruskal-google