Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change bigdecimal to development dependency #18448

Closed
wants to merge 1 commit into from
Closed

Change bigdecimal to development dependency #18448

wants to merge 1 commit into from

Conversation

y-yagi
Copy link
Contributor

@y-yagi y-yagi commented Sep 20, 2024

It seems that bigdecimal is only used in tests.
I think there is no need to treat it as runtime dependency.

@y-yagi
Change bigdecimal to development dependency
c1f2beb 
It seems that `bigdecimal` is only used in tests.
I think there is no need to treat it as runtime dependency.
@y-yagi y-yagi requested a review from a team as a code owner September 20, 2024 08:11
@y-yagi y-yagi requested review from JasonLunn and removed request for a team September 20, 2024 08:11
@JasonLunn JasonLunn added ruby 🅰️ safe for tests Mark a commit as safe to run presubmits over labels Sep 20, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Sep 20, 2024
@esrauchg esrauchg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Sep 25, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Sep 25, 2024
@JasonLunn JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 9, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 9, 2024
copybara-service bot pushed a commit that referenced this pull request Oct 9, 2024
@y-yagi @copybara-github
Change bigdecimal to development dependency (#18448)
9d84ff4 
It seems that `bigdecimal` is only used in tests.
I think there is no need to treat it as runtime dependency.

Closes #18448

COPYBARA_INTEGRATE_REVIEW=#18448 from y-yagi:fix_dependency c1f2beb
FUTURE_COPYBARA_INTEGRATE_REVIEW=#18448 from y-yagi:fix_dependency c1f2beb
PiperOrigin-RevId: 684071201
@copybara-service copybara-service bot mentioned this pull request Oct 9, 2024
Merged
copybara-service bot pushed a commit that referenced this pull request Oct 9, 2024
@y-yagi @copybara-github
Change bigdecimal to development dependency (#18448)
76034ab 
It seems that `bigdecimal` is only used in tests.
I think there is no need to treat it as runtime dependency.

Closes #18448

COPYBARA_INTEGRATE_REVIEW=#18448 from y-yagi:fix_dependency c1f2beb
FUTURE_COPYBARA_INTEGRATE_REVIEW=#18448 from y-yagi:fix_dependency c1f2beb
PiperOrigin-RevId: 681172953
@copybara-service copybara-service bot mentioned this pull request Oct 9, 2024
Closed
@copybara-service copybara-service bot closed this in 4b64df4 Oct 9, 2024
@y-yagi y-yagi deleted the fix_dependency branch October 10, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonLunn JasonLunn JasonLunn approved these changes

Assignees
No one assigned
Labels
ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@y-yagi @JasonLunn @esrauchg