-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PYTHON] Only generate protos in development #351
[PYTHON] Only generate protos in development #351
Conversation
I don't believe removing MANIFEST.in helps: that file governs what files are included when creating the "sdist", but is not in play during installation. The |
I tested it locally (and added it to CI) so it seems to work. It's another matter that the cpp_implementation tests are failing now :( |
@tamird have you tested it by running |
#360 out-of-lines the proto-generation stuff from "normal" installation, adding a new |
Hey, this is green (and it tests |
I love the code to test pip in a virtualenv. I would rather not remove MANIFEST.in, because it pollutes our distribution with stuff that doesn't belong there. Instead, to fix the build, could we simply add this at the beginning of # Unittest protos are only needed for development.
if not os.path.exists("../.git"):
return |
@@ -102,10 +104,13 @@ build_python_cpp() { | |||
./autogen.sh | |||
./configure | |||
make -j2 | |||
export LD_LIBRARY_PATH=../src/.libs | |||
export LD_LIBRARY_PATH=../src/.libs | |||
export DYLD_LIBRARY_PATH=../src/.libs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment like "# For OS X"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Done. |
Thanks a lot! Merging. |
[PYTHON] Only generate protos in development
…lity of NaN and Infinity + additional documentation of util.toJSONOptions, see protocolbuffers#351
Fixes #333.
@haberman @tseaver