Fix a bug that causes DynamicMessage.setField() to not work for repeated enum fields. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This bug was introduced to the open-source branch only because we haven't merged the change into our internal code base. Has it been integrated to our internal code base, I believe it will be rollback-ed immediately. For future releases, when we make a release candidate, we should also merge all changes back to the internal branch so we have a better chance to discover such kind of bugs earlier. |
| @@ -573,7 +579,7 @@ private void verifyOneofContainingType(OneofDescriptor oneof) { | |||
| } | |||
|
|
|||
| /** Verifies that the value is EnumValueDescriptor and matchs Enum Type. */ | |||
|
Updated. |
|
LGTM |
xfxyjwf
added a commit
that referenced
this pull request
Oct 3, 2014
Fix a bug that causes DynamicMessage.setField() to not work for repeated enum fields.
TeBoring
pushed a commit
to TeBoring/protobuf
that referenced
this pull request
Jan 19, 2019
Added lots of decoder tests and fixed lots of bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: @pherl @protobufel
Fixes #17