Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py fixes for Python 3 #50

Merged
merged 2 commits into from
Nov 8, 2014
Merged

setup.py fixes for Python 3 #50

merged 2 commits into from
Nov 8, 2014

Conversation

dlitz
Copy link
Contributor

@dlitz dlitz commented Oct 14, 2014

This should help with issue #7.

dlitz added 2 commits October 14, 2014 13:47
@dlitz
Use 2to3 when building under Python 3.
0fd260e
@dlitz
Omit google-apputils dependency under Python 3
b460610 
Temporary change until a py3k-compatible google-apputils is released.
@xfxyjwf
Copy link
Contributor

xfxyjwf commented Oct 14, 2014

@mrovner, can you take a look at this patch?

@jstasiak
Copy link

+1, would really like to see this merged

@mrovner
Copy link

mrovner commented Oct 24, 2014

LGTM

On Thu, Oct 23, 2014 at 4:12 AM, Jakub Stasiak notifications@github.com
wrote:

+1, would really like to see this merged

—
Reply to this email directly or view it on GitHub
#50 (comment).

Thanks,
--Mike

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Oct 24, 2014

Hi, @dlitz, can you sign this Google CLA and let me know when you are done?
https://cla.developers.google.com/about/google-individual?csw=1

@Kentzo
Copy link

Kentzo commented Oct 27, 2014

I'm looking forward to integrate the whole set of changes needed to make python bindings fully python 3 compatible (see my diverged fork https://github.com/GreatFruitOmsk/protobuf-py3).

Would be awesome if you guys help me there.

@xfxyjwf I accepted that license.

@dlitz
Copy link
Contributor Author

dlitz commented Nov 7, 2014

@xfxyjwf Done.

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Nov 8, 2014

Thanks, @dlitz !

xfxyjwf added a commit that referenced this pull request Nov 8, 2014
@xfxyjwf
Merge pull request #50 from dlitz/compat-py3k
ad7f41b 
setup.py fixes for Python 3
@xfxyjwf xfxyjwf merged commit ad7f41b into protocolbuffers:master Nov 8, 2014
@xfxyjwf
Copy link
Contributor

xfxyjwf commented Nov 8, 2014

@Kentzo, feel free to send us a pull request for that.

@Kentzo
Copy link

Kentzo commented Nov 8, 2014

@xfxyjwf Please see #66
It's incomplete but please feel free to review and comment what is already done.

@virtuald
Copy link

Looking forward to python3 support!

@virtuald virtuald mentioned this pull request Dec 17, 2014
Closed
@vmarkovtsev vmarkovtsev mentioned this pull request Jan 15, 2015
Open
@arnow117 arnow117 mentioned this pull request Apr 1, 2019
Closed
@yzhao1012 yzhao1012 mentioned this pull request Aug 15, 2019
Closed
gerrit-photon pushed a commit to vmware/photon that referenced this pull request May 21, 2021
@tapakund @gsujayvmw
protobuf: Fix build issue
2781374 
protobuf requires google-apputils.

For python2,  installed using pip.
For python3.5, the binary seems to be not available
in pypi. So have skipped from the requirement.

Also, google-apputils seems to be retired and it seems mostly
used for unit testing in protobuf.

Pls refer:
protocolbuffers/protobuf#50

This change completely removed google-apputils:
protocolbuffers/protobuf@7ee2583

Change-Id: I543420ae0a11dbc81196c390ed45c3ffbc842566
Signed-off-by: Tapas Kundu <tkundu@vmware.com>
Reviewed-on: http://photon-jenkins.eng.vmware.com:8082/13524
Tested-by: gerrit-photon <photon-checkins@vmware.com>
Reviewed-by: Sujay G <gsujay@vmware.com>
yordis pushed a commit to yordis/protobuf that referenced this pull request Dec 8, 2024
@tony612
Remove several unused warnings (protocolbuffers#50)
edb9aee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dlitz @xfxyjwf @jstasiak @mrovner @Kentzo @virtuald